Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix miss saving some inputs and outputs with optimize input and output storage #2841

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix: Fix miss saving some inputs and outputs with optimize input and output storage #2841

merged 1 commit into from
Sep 20, 2023

Conversation

yanguoyu
Copy link
Collaborator

Fixed Magickbase/neuron-public-issues#282.

  1. Save entity into indexer_tx_hash_cache order by the block number
  2. Create a queue to check generate address
  3. When starting the sync process, check whether there exist some lock args belonging to the Neuron wallet

@yanguoyu yanguoyu marked this pull request as draft September 16, 2023 14:00
@yanguoyu yanguoyu marked this pull request as ready for review September 16, 2023 14:36
@yanguoyu yanguoyu mentioned this pull request Sep 18, 2023
Closed
@Keith-CY
Copy link
Collaborator

Please have a review @homura @zhangyouxin @devchenyan @WhiteMinds
And please have a test simultaneously @silySuper @FrederLu

@FrederLu
Copy link
Collaborator

FrederLu commented Sep 19, 2023 •
edited by github-actions bot
Loading

/package

Packaging for test is done in 6232730760. @FrederLu

@Keith-CY Keith-CY merged commit be2c2f3 into nervosnetwork:develop Sep 20, 2023
10 checks passed
@yanguoyu yanguoyu deleted the fix-cell-opt branch September 20, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrederLu FrederLu FrederLu approved these changes

@devchenyan devchenyan devchenyan approved these changes

@Keith-CY Keith-CY Keith-CY approved these changes

@homura homura Awaiting requested review from homura

@WhiteMinds WhiteMinds Awaiting requested review from WhiteMinds

@silySuper silySuper Awaiting requested review from silySuper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Miss saving some inputs and outputs
4 participants
@yanguoyu @Keith-CY @FrederLu @devchenyan